First state machine tree init (single core)#273
Merged
Conversation
Member
Author
|
need to update the compatibility check jld2 file in repo for save and load. VariableNodeData has changed, new field |
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=========================================
Coverage ? 52.77%
=========================================
Files ? 22
Lines ? 2814
Branches ? 0
=========================================
Hits ? 1485
Misses ? 1329
Partials ? 0
Continue to review full report at Codecov.
|
Member
Author
|
xref #224 |
Collaborator
|
Cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to initialize factor graph variables using the Bayes tree and not just on the factor graph, or worse to just punt initialization to the user -- yuck.