Skip to content

deps bump ManifoldsBase to include v1 #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

deps bump ManifoldsBase to include v1 #1130

merged 3 commits into from
May 6, 2025

Conversation

dehann
Copy link
Member

@dehann dehann commented May 5, 2025

No description provided.

@dehann dehann self-assigned this May 5, 2025
@codecov Codecov
Copy link

codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.49%. Comparing base (56ade19) to head (91dcd64).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1130   +/-   ##
========================================
  Coverage    75.49%   75.49%           
========================================
  Files           28       28           
  Lines         2387     2387           
========================================
  Hits          1802     1802           
  Misses         585      585

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Affie
Affie reviewed May 6, 2025
View reviewed changes
Project.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next DFG should be v0.26.0 if I’m not mistaken.

Copy link
Member Author

@dehann dehann May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Affie, It should be fine to do a patch release. Not sure why #1128 is labelled breaking change if there are no changes to exports? Only a few other small PRs merged without breaking changes.

Also, I need a patch fix to restore all the repos for stable so trying to make it work before any real breaking changes like 1127 happen...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess you mean user needs a new package and therefore a minor release. That's probably better -- I'll just release as v0.26.0 then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. See news.md using GraphPlot -> using GraphMakie

@dehann dehann added this to the v0.26.0 milestone May 6, 2025
@dehann dehann merged commit b5593f2 into develop May 6, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Affie Affie Affie left review comments

Assignees

@dehann dehann

Labels
dependencies
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dehann @Affie