Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp playing and replaying #175

Merged

Conversation

Sid-Bhatia-0
Copy link
Member

  1. Remove Play module and move all its contents into the GridWorlds module.
  2. Remove hardcoded delimiters and simplify the format of the recording file.
  3. Don't forward get_action_names for RLBaseEnv type. Only forward show and play! for now.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #175 (66d5f7a) into master (f7b8632) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   62.92%   62.70%   -0.23%     
==========================================
  Files          27       27              
  Lines        2654     2665      +11     
==========================================
+ Hits         1670     1671       +1     
- Misses        984      994      +10     
Impacted Files Coverage Δ
src/play.jl 0.00% <0.00%> (ø)
src/rlbase.jl 25.00% <0.00%> (+5.00%) ⬆️
src/abstract_grid_world.jl 11.00% <0.00%> (-0.92%) ⬇️
src/envs/dynamic_obstacles_directed.jl 57.95% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b8632...66d5f7a. Read the comment docs.

@Sid-Bhatia-0 Sid-Bhatia-0 merged commit e630024 into JuliaReinforcementLearning:master Jul 23, 2021
@Sid-Bhatia-0 Sid-Bhatia-0 deleted the revamp_play branch July 23, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants