Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bunch of miscellaneous things #174

Merged

Conversation

Sid-Bhatia-0
Copy link
Member

  1. Update RLBase.action_space to return Base.OneTo(NUM_ACTIONS) for all environments. All environments have discrete action spaces and this is a consistent way to refer to them.
  2. Rename AbstractGridWorldGame to AbstractGridWorld.
  3. Rename get_tile_map_height to get_height and get_tile_map_width to get_width.
  4. Rename get_tile_pretty_repr and get_tile_map_pretty_repr to get_pretty_tile_map.
  5. Rename get_sub_tile_pretty_repr and get_sub_tile_map_pretty_repr to get_pretty_sub_tile_map.
  6. Update the miscellaneous section for all environments. Use CartesianIndex as argument instead of passing i and j separately to get_pretty_tile_map. Add method get_object_names and print it along with action_names in the show method. Add sub_tile_map view to almost all environments.
  7. Fix benchmarks.jl. Remove RLBaseEnvModule.
  8. Update README.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #174 (cd7194f) into master (f05079c) will decrease coverage by 9.40%.
The diff coverage is 3.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   72.40%   62.99%   -9.41%     
==========================================
  Files          27       27              
  Lines        2290     2654     +364     
==========================================
+ Hits         1658     1672      +14     
- Misses        632      982     +350     
Impacted Files Coverage Δ
src/abstract_grid_world.jl 11.92% <0.00%> (-0.12%) ⬇️
src/play.jl 0.00% <0.00%> (ø)
src/rlbase.jl 20.00% <0.00%> (ø)
src/envs/go_to_target_directed.jl 56.17% <2.94%> (-18.45%) ⬇️
src/envs/door_key_directed.jl 56.81% <3.03%> (-17.81%) ⬇️
src/envs/dynamic_obstacles_directed.jl 57.95% <3.12%> (-14.11%) ⬇️
src/envs/grid_rooms_directed.jl 55.95% <3.12%> (-17.49%) ⬇️
src/envs/maze_directed.jl 55.95% <3.12%> (-17.49%) ⬇️
src/envs/sokoban/sokoban_directed.jl 57.60% <3.12%> (-17.04%) ⬇️
src/envs/collect_gems_directed.jl 57.14% <3.22%> (-16.71%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05079c...cd7194f. Read the comment docs.

@Sid-Bhatia-0 Sid-Bhatia-0 merged commit f7b8632 into JuliaReinforcementLearning:master Jul 22, 2021
@Sid-Bhatia-0 Sid-Bhatia-0 deleted the miscellaneous branch July 22, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants