-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bunch of miscellaneous things #174
Merged
Sid-Bhatia-0
merged 19 commits into
JuliaReinforcementLearning:master
from
Sid-Bhatia-0:miscellaneous
Jul 22, 2021
Merged
update bunch of miscellaneous things #174
Sid-Bhatia-0
merged 19 commits into
JuliaReinforcementLearning:master
from
Sid-Bhatia-0:miscellaneous
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 72.40% 62.99% -9.41%
==========================================
Files 27 27
Lines 2290 2654 +364
==========================================
+ Hits 1658 1672 +14
- Misses 632 982 +350
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RLBase.action_space
to returnBase.OneTo(NUM_ACTIONS)
for all environments. All environments have discrete action spaces and this is a consistent way to refer to them.AbstractGridWorldGame
toAbstractGridWorld
.get_tile_map_height
toget_height
andget_tile_map_width
toget_width
.get_tile_pretty_repr
andget_tile_map_pretty_repr
toget_pretty_tile_map
.get_sub_tile_pretty_repr
andget_sub_tile_map_pretty_repr
toget_pretty_sub_tile_map
.CartesianIndex
as argument instead of passingi
andj
separately toget_pretty_tile_map
. Add methodget_object_names
and print it along withaction_names
in theshow
method. Addsub_tile_map
view to almost all environments.benchmarks.jl
. RemoveRLBaseEnvModule
.