Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp SequentialRoomsUndirected & SequentialRoomsDirected #155

Conversation

Sid-Bhatia-0
Copy link
Member

  1. Remove old SequentialRoomsUndirected and SequentialRoomsDirected.
  2. Add new SequentialRoomsUndirectedModule.SequentialRoomsUndirected and SequentialRoomsDirectedModule.SequentialRoomsDirected with improved implementation.
  3. Add agent_direction information to RLBase.state for directed environments when state style is InternalState.
  4. Fix and update tests. Execute RLBase.state inside tests.
  5. Update README.

Here is how the new environments look:

SequentialRoomsUndirectedModule.SequentialRoomsUndirected:

sequential_rooms_undirected

SequentialRoomsDirectedModule.SequentialRoomsDirected:

sequential_rooms_directed

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021

Codecov Report

Merging #155 (7fbad43) into master (f5a27bf) will decrease coverage by 1.40%.
The diff coverage is 76.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   73.24%   71.84%   -1.41%     
==========================================
  Files          25       26       +1     
  Lines        2396     2472      +76     
==========================================
+ Hits         1755     1776      +21     
- Misses        641      696      +55     
Impacted Files Coverage Δ
src/envs/envs.jl 72.72% <ø> (-21.03%) ⬇️
src/envs/sequential_rooms_directed.jl 57.14% <57.14%> (ø)
src/envs/sequential_rooms_undirected.jl 82.14% <82.14%> (ø)
src/rlbase.jl 82.69% <88.88%> (+24.35%) ⬆️
src/grid_world_base.jl 25.64% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a27bf...7fbad43. Read the comment docs.

@Sid-Bhatia-0 Sid-Bhatia-0 merged commit 010452d into JuliaReinforcementLearning:master Jul 4, 2021
@Sid-Bhatia-0 Sid-Bhatia-0 deleted the revamp_sequential_rooms branch July 4, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants