Skip to content

Fix time_of_commit for annotated tags #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 2 commits into from
Jan 8, 2026
Merged

Fix time_of_commit for annotated tags #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6e0634
Fix time_of_commit for annotated tags
IanButterworth Jan 8, 2026
b5bbf20
fix
IanButterworth Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tagbot/action/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,9 @@ def merge_and_delete_branch(self, branch: str) -> None:
def time_of_commit(self, sha: str, repo: str = "") -> datetime:
"""Get the time that a commit was made."""
# The format %cI is "committer date, strict ISO 8601 format".
date = self.command("show", "-s", "--format=%cI", sha, repo=repo)
# Use git log with ^{commit} to dereference tags to their underlying commit,
# since git show on annotated tags outputs the tag message before the commit.
date = self.command("log", "-1", "--format=%cI", f"{sha}^{{commit}}", repo=repo)
parsed = parse_git_datetime(date)
if not parsed:
logger.warning(
Expand Down
2 changes: 1 addition & 1 deletion test/action/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def test_merge_and_delete_branch():
def test_time_of_commit():
g = _git(command="2019-12-22T12:49:26+07:00")
assert g.time_of_commit("a") == datetime(2019, 12, 22, 5, 49, 26)
g.command.assert_called_with("show", "-s", "--format=%cI", "a", repo="")
g.command.assert_called_with("log", "-1", "--format=%cI", "a^{commit}", repo="")


@patch("subprocess.run")
Expand Down