Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework all the stuff #43

Merged
merged 10 commits into from
Dec 18, 2019
Merged

Rework all the stuff #43

merged 10 commits into from
Dec 18, 2019

Conversation

christopher-dG
Copy link
Member

@christopher-dG christopher-dG commented Dec 17, 2019

The current GitHub Action is more like a proof of concept than something I'd actually want to see in production. In terms of implementation, most of the functions have now been moved to a Repo class that holds state, instead of global state being determined by the environment variables set by GitHub Actions. This is quite a bit nicer IMO, and with it I'd say we can move forward with #34, and #39 after a testing period (and probably some integration tests).

Closes #40 (only a GitHub release is created by default, with the option to put annotated tags underneath for yourself via the dispatch input)
Closes #37 (no more GPG)
Closes #36 (no more inputs with dashes)
Closes #35 (this works now)

There is a notable lack of changelog tests, this is because I want to rework that section soon too to allow for more customization. For now, I can say that it works on my machine 🙃.

Also to note is that support for self-hosted GitHub is gone. I'll add it back if someone asks for it but I do not know of any organizations using Julia that hosts GitHub on-prem.

I'll probably merge tomorrow unless there's something awful that someone finds.

edit: not sure why CI is failing, it works locally (although it's on 3.8 vs 3.7).
Hm, this is a Python 3.7 vs 3.8 issue. 3.8 works as I would expect, 3.7 does not.

Here's a much nicer implementation that doesn't revolve around a bunch
of global state.
Issue #40 is implemented here (both the no-more GPG and the dispatch
thing), as well as #34.
That's the common case and it's way faster.
The default is utf-8 anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant