Skip to content

Look up release branch in commit comment #200

@christopher-dG

Description

@christopher-dG

@property
def _release_branch(self) -> str:
"""Get the name of the release branch."""
return self.__release_branch or self._repo.default_branch

The code above means "Static release branch set in TagBot config if it's set, otherwise the repo's default branch". It's ignoring release branch info from a Registrator invocation like @JuliaRegistrator register branch=foo.

The actual effect of this is we miss out on the nice "N commits since this release" for those latter releases.

The priority for release branch selection should be:

  1. Branch specified by Registrator invocation
  2. Release branch specified in TagBot config
  3. Default branch

Right now we're just missing (1). We can look up the commit comment by reading the registry PR body, but we're out of luck for the web UI.

I won't get to this soon but I'll keep it in mind for the rewrite ™️

Metadata

Metadata

Assignees

No one assigned

    Labels

    rewriteWill be done in the Julia rewrite of TagBot (see #55), but not before.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions