Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread new_package_waiting_period through to AutoMerge comment #552

Merged
merged 13 commits into from
Jun 12, 2024

Conversation

ericphanson
Copy link
Member

Based on #548 which should get merged first

closes #413, which is a recurring source of confusion on our private registry that uses a much lower number here

@ericphanson
Copy link
Member Author

I'm so confused about

ERROR: LoadError: LoadError: LoadError: syntax: invalid keyword argument syntax "new_package_waiting_period"
Stacktrace:
 [1] top-level scope at /home/runner/work/RegistryCI.jl/RegistryCI.jl/src/AutoMerge/pull_requests.jl:174

src/AutoMerge/util.jl Outdated Show resolved Hide resolved
@DilumAluthge
Copy link
Member

I'm so confused about

ERROR: LoadError: LoadError: LoadError: syntax: invalid keyword argument syntax "new_package_waiting_period"
Stacktrace:
 [1] top-level scope at /home/runner/work/RegistryCI.jl/RegistryCI.jl/src/AutoMerge/pull_requests.jl:174

Do you have something of the form f(; new_package_waiting_period)?

IIRC, that doesn't work on Julia 1.3. You'll need to do f(; new_package_waiting_period=new_package_waiting_period) instead.

@GunnarFarneback
Copy link
Contributor

Yes, the kwarg shortcut arrived in Julia 1.5.

@ericphanson
Copy link
Member Author

Yeah, I knew that... but still left one in. It was very confusing because the stacktrace pointed to the wrong file I think. It said

 [1] top-level scope at /home/runner/work/RegistryCI.jl/RegistryCI.jl/src/AutoMerge/pull_requests.jl:174

but that line seemed fine.

src/AutoMerge/util.jl Outdated Show resolved Hide resolved
Base automatically changed from eph/refactor-comment to master June 12, 2024 00:05
@ericphanson ericphanson added this pull request to the merge queue Jun 12, 2024
Merged via the queue into master with commit f34b6b0 Jun 12, 2024
10 of 11 checks passed
@ericphanson ericphanson deleted the eph/correct-num-days branch June 12, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants