Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: FixedRNGs v0.0.1 #86858

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: aa9b60e7-6b1c-4c29-a6e5-e43521412437
Repo: https://github.com/cscherrer/FixedRNGs.jl.git
Tree: 8d59cc073d4f69c2e70938575b708ca9ece3381b

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
JuliaRegistrator referenced this pull request in cscherrer/ConstantRNGs.jl Jul 4, 2023
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch July 4, 2023 22:12 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@gdalle
Copy link
Contributor

gdalle commented Jul 5, 2023

[noblock]

Hi @cscherrer! Judging by the name I was expecting some Quasi Monte-Carlo scheme, but looking at the code it's just a fixed number every time, so I was a bit surprised 🤣
Can I suggest a renaming to FixedNumberGenerators? The R really doesn't belong here IMHO

@cscherrer
Copy link

cscherrer commented Jul 5, 2023

[noblock]

Thanks @gdalle . I agree the name can be improved, but I think the name should either indicate that it's <:AbstractRNG, or something about the main use case. FixedNumberGenerators doens't meet either of these IMO. How about either

  • TrivialRNGs or ConstantRNGs, or
  • TestValues. Our main use case is the testvalue function, providing an arbitrary point in the support of a measure. The name is taken from PyMC, so it's maybe a little more familiar. In this case we'd bring the testvalue function here (currently it's in MeasureBase).

@oschulz any thoughts on this?

@gdalle
Copy link
Contributor

gdalle commented Jul 5, 2023

[noblock]

How about FakeRNGs?

@cscherrer
Copy link

How about FakeRNGs?

...maybe? Let's wait for input from @oschulz. There's no rush on this, just a small component of MeausureBase we realized could be independent, so we've talked about factoring it out for wider use.

[noblock]

@oschulz
Copy link
Contributor

oschulz commented Jul 5, 2023

Hmmm there are fixed, but also not random, but they are (and have to be) subtypes of AbstractRNG. Maybe something like "DummyRNGS"?

[noblock]

@cscherrer
Copy link

DummyRNGs works for me. What do you think @gdalle ?

[noblock]

@gdalle
Copy link
Contributor

gdalle commented Jul 5, 2023

[noblock]

I agree that it fits, but I must say I don't like the connotations.

pandas-dev/pandas#35724

Perhaps ConstantRNGs.jl?

@cscherrer
Copy link

[noblock]

Oof, good point. Ok, let's go with ConstantRNGs, I think that captures everything we need. Thanks for the discussion @gdalle

@cscherrer
Copy link

@gdalle I re-registered as ConstantRNGs (#86926). Does that mean we should kill this one? Or keep this and kill the new one?
[noblock]

@DilumAluthge DilumAluthge deleted the registrator-fixedrngs-aa9b60e7-v0.0.1-6f30d77467 branch July 6, 2023 00:16
@oschulz
Copy link
Contributor

oschulz commented Jul 6, 2023

I like ConstantRNGs too.

[noblock]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants