-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: FixedRNGs v0.0.1 #86858
New package: FixedRNGs v0.0.1 #86858
Conversation
JuliaRegistrator
commented
Jul 4, 2023
- Registering package: FixedRNGs
- Repository: https://github.com/cscherrer/FixedRNGs.jl
- Created by: @cscherrer
- Version: v0.0.1
- Commit: 167a785e19492d5799b3f16cfece27dd6fbfd372
- Reviewed by: @cscherrer
- Reference: cscherrer/ConstantRNGs.jl@167a785#commitcomment-120649593
- Description: A simple deterministic RNG, for cases when you need high efficiency and don't care about randomness
UUID: aa9b60e7-6b1c-4c29-a6e5-e43521412437 Repo: https://github.com/cscherrer/FixedRNGs.jl.git Tree: 8d59cc073d4f69c2e70938575b708ca9ece3381b Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
Your Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1 If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
[noblock] Hi @cscherrer! Judging by the name I was expecting some Quasi Monte-Carlo scheme, but looking at the code it's just a fixed number every time, so I was a bit surprised 🤣 |
[noblock] Thanks @gdalle . I agree the name can be improved, but I think the name should either indicate that it's
@oschulz any thoughts on this? |
[noblock] How about |
...maybe? Let's wait for input from @oschulz. There's no rush on this, just a small component of MeausureBase we realized could be independent, so we've talked about factoring it out for wider use. [noblock] |
Hmmm there are fixed, but also not random, but they are (and have to be) subtypes of [noblock] |
DummyRNGs works for me. What do you think @gdalle ? [noblock] |
[noblock] I agree that it fits, but I must say I don't like the connotations. Perhaps ConstantRNGs.jl? |
[noblock] Oof, good point. Ok, let's go with ConstantRNGs, I think that captures everything we need. Thanks for the discussion @gdalle |
I like ConstantRNGs too. [noblock] |