Skip to content

New package: SciMLPublic v1.0.0 #129643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Apr 23, 2025

Copy link
Contributor

github-actions bot commented Apr 23, 2025

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

UUID: 431bcebd-1456-4ced-9d72-93c2757fff0b
Repo: https://github.com/SciML/SciMLPublic.jl.git
Tree: ed647f161e8b3f2973f24979ec074e8d084f1bee

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-scimlpublic-431bcebd-v1.0.0-0849d9a373 branch from 00fce54 to 513ef24 Compare April 23, 2025 12:11
@goerz
Copy link
Member

goerz commented Apr 23, 2025

[noblock] Although it is probably obvious to people intimately familiar with the public keyword that was added in Julia 1.11, I would very much recommend adding a few paragraphs to the README of this package to give context. Explain what problem this package tries to solve, what the alternative solutions and tradeoffs are, and what the policies for using SciMLPublic.jl within the SciML organization are. You might want to link to the Discourse discussion on "Is Compat.jl worth it for the public keyword?" (and, maybe also add a post to the thread to "announce" this new package). Maybe mention https://github.com/JuliaLang/Public.jl and explain why, even though there was pushback against registering that package, it was deemed sufficiently useful in the context of SciML to register it now.

@JuliaTagBot JuliaTagBot merged commit a0b0de4 into master Apr 26, 2025
9 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-scimlpublic-431bcebd-v1.0.0-0849d9a373 branch April 26, 2025 12:07
@AayushSabharwal
Copy link
Contributor

[noblock] Thanks for the input. I'll make the suggested changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants