Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Oceananigans v0.93.0 #118125

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 9e8cae18-63c1-5223-a75c-80ca9d6e9a09
Repo: https://github.com/CliMA/Oceananigans.jl.git
Tree: 798f04c6c509f0f3da9bf24fd1849d5d9d3c45a0

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in CliMA/Oceananigans.jl Oct 26, 2024
* Use `with_halos=true` default for `JLD2OutputWriter`

I keep getting bit by this, so I think its time to make the change. We'll see if there are any tests that assume the default.

* Update jld2_output_writer.jl

* using makie ext

* more makie ext

* drop oceananigans from docs toml

* no need to find nodes

* use makie ext

* Update src/OutputWriters/jld2_output_writer.jl

* Add with_halos=false to simulation test

* Update doctests

* drop nodes

* convert doctests with file size output to examples

* Revert "convert doctests with file size output to examples"

This reverts commit c411449.

* Reapply "convert doctests with file size output to examples"

This reverts commit 6001867.

* fix example

* bump minor release

* fix docstring

* Apply suggestions from code review

Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>

* homogenize examples

* fix docs built

* use absolute path

* use relative paths in show

---------

Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit eccd26b into master Oct 26, 2024
20 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-oceananigans-9e8cae18-v0.93.0-c090128d9e branch October 26, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants