Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: AbstractMCMC v5.5.0 #117303

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

This PR introduce two functions on sampler state, `getparams` and `setparams!!`. `getparams` allows retrieving the values of the parameters as a vector. `setparams!!` is the counter part of `getparams`. 

This is part of the effort of making interaction between samplers easier. The motivation of this PR is that a "high-order" MCMC (e.g. Gibbs) can use `getparams` and `setparams!!` without having to know the exact type of the sampler state, thus paving way to a more generalized sampler design and implementation.

UUID: 80f14c24-f653-4e6a-9b94-39d6b0f70001
Repo: https://github.com/TuringLang/AbstractMCMC.jl.git
Tree: c732dd9f356d26cc48d3b484f3fd9886c0ba8ba3

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in TuringLang/AbstractMCMC.jl Oct 15, 2024
* added state_from_transition, parameters and setparameters!!

* Update src/AbstractMCMC.jl

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>

* renamed state_from_transition to updatestate!!

* adhere to julia convention

* added docs

* fixed docs

* fixed docs

* added example for why updatestate!! is useful

* improved MixtureState example

* further improvements to docs

* renamed parameters and setparameters!! to values and setvalues!!

* fixed typo in docs

* fixed documenting values

* improved and fixed some bugs in docs

* fixed typo in docs

* renamed values and setvalues!! to realize and realize!!

* added model to updatestate!!

* Apply suggestions from code review

Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update docs/src/api.md

Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>

* Update docs/src/api.md

Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>

* version bump

---------

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Xianda Sun <sunxdt@gmail.com>
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round.

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 229a4f9 into master Oct 15, 2024
15 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-abstractmcmc-80f14c24-v5.5.0-a23787a7d7 branch October 15, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants