Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: PYTHIA8 v0.1.0 #115979

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

## Initial release

UUID: ab9774ad-7527-4370-92ef-86b02700ecc9
Repo: https://github.com/JuliaHEP/PYTHIA8.jl.git
Tree: 7aaa008e4fc205ccc185f7d0a7e9a8d683273c3b

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@peremato
Copy link
Contributor

[noblock] @goerz Can you please unblock the request with this new name. Thanks!

@goerz
Copy link
Member

goerz commented Sep 25, 2024

[noblock] So yeah, unfortunately, this still caught the "not all letters are upper-case" check, which I can't override. But it should be fine. You just have to go back on Slack in three days and ask for a maintainer to merge it manually. I don't see this PR as particularly controversial, so it's just a matter of getting someone's attention

@peremato
Copy link
Contributor

Thanks!

@carstenbauer
Copy link
Member

[noblock] Why is this called PYTHIA8.jl, that is, why is the version number included in the package name? If a version 9 of the upstream package is released, should we expect a PYTHIA9.jl? That doesn't seem ideal. Otherwise I think this can be merged.

@Moelf
Copy link

Moelf commented Sep 29, 2024

[noblock] very good question, for some reason HEP has settled to this pattern:

@peremato
Copy link
Contributor

[noblock] PYTHIA6 was written in FORTRAN, PYTHIA8 is in C++. If ever there is a PYTHIA9 will be written on a different language, perhaps in Julia 😄, so we do not expect a PYTHIA9 in the immediate future.

@carstenbauer
Copy link
Member

Alright, I take it that these different "versions" are more like entire rewrites, in which case this makes sense. I'll go ahead and merge this.

@carstenbauer carstenbauer merged commit 2c17c87 into master Sep 29, 2024
24 of 27 checks passed
@carstenbauer carstenbauer deleted the registrator-pythia8-ab9774ad-v0.1.0-e858c4a0d2 branch September 29, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants