Python setup #39
Merged
Python setup #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdoris
requested changes
Sep 29, 2021
There was a problem hiding this comment.
Thanks for the PR! The setup.py looks great but please can you revert the documentation?
I want this part of the documentation at least to be as friendly as possible to newcomers, so don't want too much developer-specific information. I'd expect most developers to know this stuff already anyway. There could be a CONTRIBUTING.md at the top of the repo with more detailed info, but that's for another PR.
Makes sense. Done. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setup.py such that even pip of an old version can work (reference). See issue #38 .