Skip to content

various fixes to array conversions #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 22, 2019
Merged

various fixes to array conversions #668

merged 8 commits into from
Mar 22, 2019

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Mar 19, 2019

Add bounds-checking, GC rooting, and CartesianIndex support in PyArray. Fixes conversion for arrays of pointers/pyptrs and 0-dimensional arrays.

Fixes JuliaPy/PyPlot.jl#431

@stevengj
Copy link
Member Author

So far I'm not able to reproduce the Travis failure on nightly locally. @tkf, does it work for you?

@tkf
Copy link
Member

tkf commented Mar 22, 2019

I checked this branch with 1.2.0-DEV.339 at-colon/00f257d603 and 1.2.0-DEV.521 b076d04bf4 both built from the git repository. I couldn't reproduce the failure in Travis.

I also downloaded 1.2.0-DEV.518 54fe55b370 from nightly build and ran the test. I still couldn't get the failure.

@stevengj
Copy link
Member Author

stevengj commented Mar 22, 2019

Thanks for checking!

I tried restarting Travis and the problem seems to have gone away! So maybe it was a temporary bug that I was triggering in nightly that got fixed.

Now I'm seeing an unrelated failure:

The following packages have unmet dependencies:
 python3.4-venv : Depends: python-setuptools-whl but it is not installable
                  Depends: python-pip-whl but it is not installable
E: Unable to correct problems, you have held broken packages.

I will restart Travis again in case this is a temporary Travis hiccup, since I wasn't seeing this yesterday.

@stevengj
Copy link
Member Author

Yay, it's green now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants