Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposes a 3D quiver #3134

Merged
merged 12 commits into from
Nov 13, 2020
Merged

Proposes a 3D quiver #3134

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3f2a55
adds 3d quiver if z component is present.
kellertuer Nov 10, 2020
501f33f
Fix SVG scaling problem
jheinen Nov 10, 2020
f3b6221
Update Project.toml
jheinen Nov 10, 2020
ac8e1d7
add linestyle to contour plots (#3139)
BeastyBlacksmith Nov 12, 2020
5d26068
fix limits in GR image
daschw Nov 12, 2020
40e1379
add new test example
daschw Nov 12, 2020
a38e473
Update precompile_*.jl file
daschw Nov 12, 2020
60a7e41
Update precompile_*.jl file
daschw Nov 12, 2020
9c0b2ea
add 3d quiver test example
daschw Nov 13, 2020
d1aa209
Merge branch 'master' into quiver3
daschw Nov 13, 2020
abebbdd
fixes two checks for 3D to work properly.
kellertuer Nov 13, 2020
7e8eb5a
Merge branch 'quiver3' of github.com:kellertuer/Plots.jl into quiver3
kellertuer Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes two checks for 3D to work properly.
  • Loading branch information
@kellertuer
kellertuer committed Nov 13, 2020
commit abebbdd54aab9ec673a7557e7379010ad2307804
4 changes: 2 additions & 2 deletions src/recipes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,15 +1197,15 @@ function quiver_using_arrows(plotattributes::AKW)
if !isa(plotattributes[:arrow], Arrow)
plotattributes[:arrow] = arrow()
end
is_3d = haskey(plotattributes,:z)
is_3d = haskey(plotattributes,:z) && !isnothing(plotattributes[:z])
velocity = error_zipit(plotattributes[:quiver])
xorig, yorig = plotattributes[:x], plotattributes[:y]
zorig = is_3d ? plotattributes[:z] : []

# for each point, we create an arrow of velocity vi, translated to the x/y coordinates
x, y = zeros(0), zeros(0)
is_3d && ( z = zeros(0))
for i = 1:max(length(xorig), length(yorig), length(zorig))
for i = 1:max(length(xorig), length(yorig), is_3d ? 0 : length(zorig))
# get the starting position
xi = _cycle(xorig, i)
yi = _cycle(yorig, i)
Expand Down