Skip to content

Avoid eval in uparse in simple cases #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid eval in uparse in simple cases #657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832ca8c
Avoid eval in uparse in simple cases
amilsted Jun 19, 2023
d330ddc
Oops.
amilsted Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/user.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,10 @@ julia> uparse("1.0*dB")
"""
function uparse(str; unit_context=Unitful)
ex = Meta.parse(str)
eval(lookup_units(unit_context, ex))
# Since eval breaks precompilation, avoid it in simple cases
isa(ex, Symbol) && return lookup_units(unit_context, ex)
isa(ex, Number) && return lookup_units(unit_context, ex)
return eval(lookup_units(unit_context, ex))
end

const allowed_funcs = [:*, :/, :^, :sqrt, :√, :+, :-, ://]
Expand Down