Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build #8

Merged
merged 5 commits into from
Aug 1, 2019
Merged

Fix windows build #8

merged 5 commits into from
Aug 1, 2019

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Jul 31, 2019

No description provided.

@NHDaly NHDaly force-pushed the windows-build branch 2 times, most recently from 12a96a7 to a7eb093 Compare July 31, 2019 13:51
@NHDaly
Copy link
Member Author

NHDaly commented Jul 31, 2019

Once we configure AppVeyor to run PRs, and verify that this fixed things, we can merge this. :)

https://ci.appveyor.com/project/NHDaly/pprof-jl

@vchuravy vchuravy closed this Jul 31, 2019
@vchuravy vchuravy reopened this Jul 31, 2019
@vchuravy
Copy link
Member

I enabled Appveyor let's see if that works or if we need to merge this first

@NHDaly
Copy link
Member Author

NHDaly commented Jul 31, 2019

Is it possible to add me as an admin to the AppVeyor so that i can cancel a build when i screwed it up, etc?

@NHDaly NHDaly merged commit 00ba82b into master Aug 1, 2019
@NHDaly NHDaly deleted the windows-build branch August 1, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants