Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pprof_jll to 0.1, which is the latest release (as of last year) #41

Merged
merged 3 commits into from
Dec 27, 2021

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Nov 3, 2021

This pulls in: JuliaPackaging/Yggdrasil#2096

I'm surprised we hadn't done this already! I haven't noticed names with " in them not working in a while, but it seems like we weren't picking up this change until now.. 🤷

@NHDaly
Copy link
Member Author

NHDaly commented Nov 3, 2021

merged in master to get CI running again.

Somehow i believe i've run into this issue today, coincidentally, after starting this branch yesterday when i noticed it was still using an older version! Life is weird :)

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #41 (5c9146c) into master (355f4f5) will decrease coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   98.13%   97.20%   -0.94%     
==========================================
  Files           2        2              
  Lines         215      215              
==========================================
- Hits          211      209       -2     
- Misses          4        6       +2     
Impacted Files Coverage Δ
src/PProf.jl 97.41% <0.00%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355f4f5...5c9146c. Read the comment docs.

@vchuravy
Copy link
Member

vchuravy commented Nov 3, 2021

Let's drop 1.0 support

@NHDaly
Copy link
Member Author

NHDaly commented Dec 27, 2021

i didn't merge this because i was confused about whether it was actually working... it seemed like i still wasn't seeing the fixes i expected, but i think i actually just misremembered what our PRs to the upstream pprof package did. :) So i'm good to merge this now.

Let's drop 1.0 support

Yeah, sounds good to me. i'll follow up with that

@NHDaly NHDaly merged commit 7e2710d into master Dec 27, 2021
@NHDaly NHDaly deleted the nhd-upgrade-pprof_jll branch December 27, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants