Support Metadata like Threadid #40
Conversation
|
Cool, what's meta? |
|
metadata like threadid |
There was a problem hiding this comment.
LGTM other than deciding whether we want to require include_meta if the user passes in a fetched profile. If so, we should add a test that we do throw the expected assertion.
This is really nice and simple! Sorry it took me so long to review! :) Thanks for the PR
|
Omg wow, OMG no - TWO YEARS LATER! Yikes |
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 96.66% 96.91% +0.24%
==========================================
Files 3 3
Lines 300 324 +24
==========================================
+ Hits 290 314 +24
Misses 10 10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Okay, I think this LGTM! I did end up adding backwards compatibility, so this should support older versions of julia as well. :)
Thanks for the PR valentin! Sorry it took me literally years to get to this. 😑
The next thing we need to do is go harass google/pprof to add the ability to filter by tags in the UI!
…atch every sample Fix the bugs in handling those cases :)
|
It seems that the tests are broken on ubuntu, even on master. I'm inclined to merge this and deal with the broken tests later. Tests pass locally for me. :) |
No description provided.