Add ui_relative_percentages=true which controls -relative_percentages in pprof.
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges` in pprof. By default, this now causes `ignore`/`hide` events through the Web UI to recompute percentages. This allows you to filter out parts of the program that aren't relevant to what you're measuring, such as `__psynch_cvwait` in a single-threaded program. However, sometimes users may simply be using `ignore`/`hide` to get a "cleaner" view of their data, but very much _don't_ want filtering the _view_ to affect the underlying data. In that case, users can disable this feature via `ui_relative_percentages=false`
NHDaly
commented
Apr 19, 2020
vchuravy
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, this now causes
ignore/hideevents through the Web UI torecompute percentages.
This allows you to filter out parts of the program that aren't relevant
to what you're measuring, such as
__psynch_cvwaitin a single-threadedprogram.
However, sometimes users may simply be using
ignore/hideto get a"cleaner" view of their data, but very much don't want filtering the
view to affect the underlying data. In that case, users can disable
this feature via
ui_relative_percentages=falseI called the flag
ui_relative_percentagesinstead ofrelative_percentages, because it is only meaningful if opening the web ui, not when just generating a.pb.gzdump.Addresses step 1 of #19.