Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-rename out= files with the .pb.gz extension if not provided. #15

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Auto-rename out= files with the .pb.gz extension if not provided. #15

merged 2 commits into from
Dec 13, 2019

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Nov 22, 2019

Adds tests for this as well.

CC: @tomasrelai

@NHDaly
Copy link
Member Author

NHDaly commented Nov 23, 2019

Weird that the windows test is failing on julia master... seems like maybe a fluke?
Also, since this is a slight API change, i should probably at least bump the patch number. Lemme do that now before merging.

@NHDaly
Patch version bump: v0.3.2: Automatically rename output files to `.pb…
4be9197 
….gz`

- #12: Use public API to lookup frames
- #15: Auto-rename `out=` files with the `.pb.gz` extension if not provided.
@NHDaly NHDaly added the enhancement New feature or request label Nov 23, 2019
@NHDaly NHDaly self-assigned this Nov 23, 2019
@NHDaly NHDaly merged commit d6f9855 into master Dec 13, 2019
@NHDaly NHDaly deleted the enforce-.pb.gz branch December 13, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees

@NHDaly NHDaly

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NHDaly @vchuravy