In the expression returned by the parse_pstats_options function, expand the output of parse_groups#32
Merged
vchuravy merged 2 commits intoJuliaPerf:masterfrom Aug 4, 2023
DilumAluthge:dpa/parse_groups
Merged
In the expression returned by the parse_pstats_options function, expand the output of parse_groups#32vchuravy merged 2 commits intoJuliaPerf:masterfrom DilumAluthge:dpa/parse_groups
parse_pstats_options function, expand the output of parse_groups#32vchuravy merged 2 commits intoJuliaPerf:masterfrom
DilumAluthge:dpa/parse_groups
Conversation
…lly qualify the `parse_groups` function
Collaborator
Author
|
cc: @vchuravy |
vchuravy
reviewed
Jul 31, 2023
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
DilumAluthge
changed the title
parse_pstats_options function, fully qualify the parse_groups functionparse_pstats_options function, expand the output of parse_groups
Collaborator
Author
|
@vchuravy Is the CI failure expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: I want to use
parse_pstats_optionsoutside of LinuxPerf.jl, so we need to changeparse_groupstoLinuxPerf.parse_groupsto make sure it works even ifparse_groupsis not in scope.Needed for JuliaCI/BenchmarkTools.jl#325
Note:
parse_pstats_optionsis internal to LinuxPerf.jl, so downstream users ofparse_pstats_options(like myself) should set the[compat]for LinuxPerf.jl to the exactmajor.minor.patchversion.