Repository navigation
Conversation
…C trim safety. An environment flag called JULIA_MPI_TRIM_SAFE is introduced to branch in parts of the package that aren't trimmable. This addresses issue JuliaParallel#931.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworking how init and load time hooks are handled to allow for JuliaC trim safety.
add_load_time_hook!andadd_init_hook!methods have a new method called_setup_load_time_<file_name>rather than relying on the module level arrays of hooks which caused juliac errors under trim.With these changes I was able to compile the following program into a 2.7Mb binary that works!
Here is the set of JuliaC commands I used
which I built with
I have not tried to test every function within the package. I view this as an initial push towards allowing for MPI aware small binaries.
The test suite passes locally as well as the test suite for PartitionedArrays
This addresses issue #931.