Add different request types #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
force-pushed
the
sb/multirequest
branch
2 times, most recently
from
8516eda to
9b0b793
Compare
simonbyrne
force-pushed
the
sb/multirequest
branch
2 times, most recently
from
f543c96 to
e7e6a20
Compare
simonbyrne
force-pushed
the
sb/multirequest
branch
from
e7e6a20 to
c0bf421
Compare
vchuravy
approved these changes
Dec 21, 2022
|
|
||
| # abstract element type to work around lack of cyclic type definitions | ||
| # https://github.com/JuliaLang/julia/issues/269 | ||
| abstract type AbstractMultiRequest <: AbstractVector{AbstractRequest} |
There was a problem hiding this comment.
What did you want to define orginally? I don't see the mutually recursive behavior.
There was a problem hiding this comment.
the element type will really be MultiRequestItem{MR} where MR is the subtype of AbstractMultiRequest
This was referenced Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines an
AbstractRequestinterface, and allows passingRequestobjects as arguments toIsend/Irecvin order to minimize allocations (as a potential solution to #645).MultiRequestwhich is essentially a vector-form Request object, but stored in the correct format.MultiRequestItemwhich is a view into a single element of aMultiRequest.UntrackedRequest/UntrackedMultiRequestwhich are variants that don't maintain a reference to the buffer.