Skip to content

no need for mutable struct with container fields #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2022
Merged

no need for mutable struct with container fields #636

merged 1 commit into from
Sep 30, 2022

Conversation

t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Sep 21, 2022

There is no need for the struct to be mutable when the struct field are containers.

giordano
giordano approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However this would be made redundant by #645, but not sure where that PR is heading to.

@simonbyrne simonbyrne merged commit 4e8dcd0 into JuliaParallel:master Sep 30, 2022
@simonbyrne
Copy link
Member

#645 is on hold

@t-bltg t-bltg deleted the mutable branch September 30, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-bltg @simonbyrne @giordano