Skip to content

switch GPU CI to buildkite #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

switch GPU CI to buildkite #439

wants to merge 3 commits into from

Conversation

simonbyrne
Copy link
Member

No description provided.

@simonbyrne simonbyrne force-pushed the sb/buildkite branch 13 times, most recently from 097a89c to b4e65b3 Compare November 16, 2020 19:01
@simonbyrne simonbyrne mentioned this pull request Nov 17, 2020
Open
simonbyrne
simonbyrne commented Nov 19, 2020
View reviewed changes
@simonbyrne simonbyrne force-pushed the sb/buildkite branch 2 times, most recently from 61a6abb to 969e311 Compare November 19, 2020 18:34
simonbyrne
simonbyrne commented Nov 19, 2020
View reviewed changes
src/cuda.jl
@@ -1,6 +1,7 @@
import .CUDA

function Base.cconvert(::Type{MPIPtr}, buf::CUDA.CuArray{T}) where T
CUDA.synchronize(CUDA.CuDefaultStream())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vchuravy What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this again?

cc: @maleadt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#443

@simonbyrne
Copy link
Member Author

The decision here was to require users to manually synchronise. We will need to update docs and the tests.

@simonbyrne simonbyrne added this to the 1.0 milestone Aug 27, 2021
@vchuravy
Copy link
Member

No part of #552

@vchuravy vchuravy closed this Apr 15, 2022
@vchuravy vchuravy deleted the sb/buildkite branch April 15, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

@maleadt maleadt maleadt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonbyrne @vchuravy @maleadt