Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCIP_PaPILO] up scip 920 #9746

Merged
merged 10 commits into from
Dec 27, 2024
Merged

Conversation

matbesancon
Copy link
Contributor

No description provided.

@matbesancon matbesancon changed the title up scip 920 [SCIP] up scip 920 Nov 6, 2024
@matbesancon matbesancon changed the title [SCIP] up scip 920 [SCIP_PaPILO] up scip 920 Nov 6, 2024
@matbesancon
Copy link
Contributor Author

If someone knows what can be going on with linking fortran on windows? It just seems not to recognize the fortran symbols at all:
https://buildkite.com/julialang/yggdrasil/builds/15459#0193b0bb-caf0-4e11-b954-9a494a58484a/6-8443

@matbesancon
Copy link
Contributor Author

For OSX, since the TBB version hasn't changed since the last build, no clue what is going on:

[16:15:25] /opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/usr/local/include/tbb/../oneapi/tbb/detail/_task_handle.h:56:5: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.13 or newer
[16:15:25]    56 |     ~task_handle_task() override {
[16:15:25]       |     ^
[16:15:25] /opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/usr/local/include/tbb/../oneapi/tbb/detail/_task_handle.h:56:5: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/scip/src/lpi/lpi_spx2.cpp:98:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/soplex/src/soplex.h:75:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/soplex/src/soplex/spxpapilo.h:156:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/papilo/src/papilo/core/Presolve.hpp:33:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/papilo/src/papilo/core/PresolveMethod.hpp:27:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/papilo/src/papilo/core/ConstraintMatrix.hpp:33:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/papilo/src/papilo/core/SingleRow.hpp:27:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/papilo/src/papilo/core/VariableDomains.hpp:31:
[16:15:25] In file included from /workspace/srcdir/scipoptsuite-9.2.0/papilo/src/papilo/misc/tbb.hpp:57:
[16:15:25] In file included from /opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/usr/local/include/tbb/parallel_for.h:17:
[16:15:25] /opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/usr/local/include/tbb/../oneapi/tbb/parallel_for.h:66:8: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.13 or newer

@imciner2
Copy link
Member

It looks like oneTBB isn't on the aarch64 FreeBSD build yet. While I am working on an update that would include that arch hopefully (#10082), that wouldn't be this version specified in the dependency - and if I recall, oneTBB changed their API a lot at some point after 2021.9.0, so updating to the new version might not be easy without upstream actually doing it.

To make this build, we need to filter out that platform

filter!(p -> !(Sys.isfreebsd(p) && arch(p) == "aarch64"), platforms)

We probably should also filter out the RISC-V architecture for now (since again, oneTBB won't be present).

filter!(p -> !(Sys.islinux(p) && arch(p) == "riscv64"), platforms)

@imciner2
Copy link
Member

If someone knows what can be going on with linking fortran on windows? It just seems not to recognize the fortran symbols at all:

@matbesancon it is basically just the comment from the last SCIP_PaPILO update here: #8224 (comment). Basically, it looks like we still need to include that patch to enable the Fortran language for that one executable - so it looks like upstream hasn't fixed that issue yet.

@matbesancon matbesancon reopened this Dec 27, 2024
@imciner2
Copy link
Member

So, I'm not sure why TBB is now giving us this error on macOS, but one possible solution would be to just bump the macOS SDK version to be 10.13 so that we then get the required function. I don't think there would be any problems with that, @matbesancon are you fine with that?

@matbesancon
Copy link
Contributor Author

yes this would work for me :)

@giordano giordano marked this pull request as draft December 27, 2024 21:51
@giordano giordano marked this pull request as ready for review December 27, 2024 21:51
@imciner2 imciner2 merged commit a7687f9 into JuliaPackaging:master Dec 27, 2024
19 checks passed
@imciner2
Copy link
Member

Ok, everything works. I did notice that the make install step seems to actually be doing quite a bit of compilation still, so it would be good to add a -j${nproc} to that step as well on the next update.

@matbesancon matbesancon deleted the scip-papilo920 branch December 28, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants