[finufft] Support for AVX512 platforms #6009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, FINUFFT.jl does not work on the new Zen 4 Ryzen series since there is no binary for AVX512 platforms available in finufft_jll. Hence, disable AVX512 via CFLAGS on x86 to provide binaries for AVX512 platforms such as Zen 4 without introducing the performance issues mentioned in the comment of line 38.
jkrimmer
changed the title
giordano
reviewed
Dec 19, 2022
| @@ -36,7 +39,7 @@ install -Dvm 0755 "lib/libfinufft.${dlext}" "${libdir}/libfinufft.${dlext}" | |||
|
|
|||
| # Expand for microarchitectures on x86_64 (library doesn't have CPU dispatching) | |||
| # Tests on Linux/x86_64 yielded a slow binary with avx512 for some reason, so disable that | |||
| platforms = expand_cxxstring_abis(expand_microarchitectures(supported_platforms(), ["x86_64", "avx", "avx2"]); skip=!Sys.iswindows) | |||
| platforms = expand_cxxstring_abis(expand_microarchitectures(supported_platforms(), ["x86_64", "avx", "avx2", "avx512"]); skip=!Sys.iswindows) | |||
There was a problem hiding this comment.
This won't work because of JuliaPackaging/BinaryBuilder.jl#1194 and JuliaPackaging/BinaryBuilderBase.jl#233
There was a problem hiding this comment.
Oh, well, it works precisely because you disabled avx512 instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, FINUFFT.jl does not work on the new Zen 4 Ryzen series since there is no binary for AVX512 platforms available in finufft_jll. Hence, disable AVX512 via CFLAGS on x86 to provide binaries for AVX512 platforms such as Zen 4 without introducing the performance issues mentioned in the comment of line 38.