Skip to content

[mbedtls] Add Mbedtls 2.27 #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2021

Conversation

jeremiahpslewis
Copy link
Contributor

@jeremiahpslewis jeremiahpslewis commented Oct 17, 2021

@giordano giordano added the julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies label Oct 17, 2021
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
@jeremiahpslewis
Copy link
Contributor Author

@giordano I kind of wonder whether this whole mbedtls setup is worth a rewrite...

  • Lots of duplicated code by each version
  • Each version is kept in code, instead of just overwriting the old one (why do we do this with mbedtls and not elsewhere?)

Thoughts?

@giordano
Copy link
Member

giordano commented Oct 17, 2021

Lots of duplicated code by each version

Where are the duplicates? It looks to me the idea is to minimise them?

Each version is kept in code, instead of just overwriting the old one (why do we do this with mbedtls and not elsewhere?)

For some packages, most notably Julia dependencies such as mbedtls, we occasionally need to go back and rebuild an old version. We do the same for LLVM and OpenBLAS, for example

@giordano giordano merged commit 49d5ab2 into JuliaPackaging:master Oct 17, 2021
@jeremiahpslewis
Copy link
Contributor Author

Fair point, if we want to keep around the older versions not much. Only remaining quibble would be that we have a couple of 2.24-specific statements that are being carried along in common.jl, but this probably can't be helped.

simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
* [mbedtls] Add 2.27

* Curse of the missing trailing comma

* Update M/MbedTLS/MbedTLS@2.27.0/build_tarballs.jl

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants