make libtask compatible with Julia 1.6 #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, 1.6/nightly-build is not available now? |
|
See #1987 |
|
Problem with that one is that apparently Julia packages and in particular JLLs are not supposed to use the "prerelease" part of a semver version... Which is kind of a pity, as they would be the absolutely natural thing to deal with JLLs bundling prerelease snapshot of software (as done in #1987, and also in a bunch of other JLLs I myself work on). Not to mention the possibility to use it to deal with Julia versions etc. :-( |
|
Some internal julia structures may have changed? |
|
Probably some additional changes in task.c after the PR was created: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.