-
Notifications
You must be signed in to change notification settings - Fork 637
libjulia: New global variable supported_julia_versions
#12207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
libjulia: New global variable supported_julia_versions
#12207
Conversation
@barche @benlorenz @fingolfin @lgoettgens are you happy with this? |
@eschnett could you maybe give some motivation for this? I don't quite understand what this new variable is supposed to mean and how it is intended to be used. |
I guess one could then use Various packages already use the default It wont help much (for dropping old versions) unless we somehow get people to adopt this, a while ago I tried to collect packages which do still support older julia versions: |
Yes, that is the intended use. I'd be happy to switch the value of |
Both of the options only change what julia versions dependents of libjulia build for (either opt-in or opt-out). But I don't see how this eventually allows us to drop the libjulia builds for these julia versions from the libjulia recipe. Of course one (maybe a bit too drastic) version would be to replace |
Would |
It might be better to have a function instead of a variable, something like |
I'd tend to agree with Bart. Also, "supported" bit is misleading, builds are available and would work, it's just that for most cases it may not be worth it having builds all the way down to v1.6, also because that just generate a ginormous number of artifacts (which also slows down the infrastructure here in Yggdrasil). |
The point is to move the constant |
You are right that this would get rid of the constant in
And since it appears in two places in the recipe, I would prefer to not move one of these to a different file. In particular, if we at some future point adapt this common definition, and someone rebuilds without changing the julia_compat in their recipe, they will get a confusing to use package (as it is missing some artifacts). |
So if one wants to centralize, the alternative would be to have a global I guess one then would only introduce that, and adjust the |
I think there are two problems to solve: one is how to allow individual package maintainers to select applicable versions, the other is how to bump the minimal version for the entire ecosystem. I don’t think there is a consensus on the latter, e.g libcxxwrap-julia still is on 1.6. |
The first ("allow individual package maintainers to select applicable versions") is not a problem. You can just filter the versions in the package's build script. I'm trying to address the second here, answering the question: "Please give me a list of versions for which I should build my package, if I don't want to think too hard myself about this question." |
I always thought |
Very good then, |
[skip ci]