Skip to content

Precompile to reduce latency #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Precompile to reduce latency #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7863789
Precompile to reduce latency
timholy Jan 31, 2022
27669c6
Omit one precompile
timholy Jan 31, 2022
c52b1f2
Improved implementations
timholy Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/Preferences.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,6 @@ function load_preference(uuid::UUID, key::String, default = nothing)
if currently_compiling()
Base.record_compiletime_preference(uuid, key)
end
# Drop any nested `__clear__` keys:
function drop_clears(data::Dict)
delete!(data, "__clear__")
for (k, v) in data
if isa(v, Dict)
drop_clears(v)
end
end
return data
end
drop_clears(x) = x

return drop_clears(get(d, key, default))
end
function load_preference(m::Module, key::String, default = nothing)
Expand Down Expand Up @@ -290,4 +278,12 @@ macro delete_preferences!(prefs...)
end
end

# Precompilation to reduce latency (https://github.com/JuliaLang/julia/pull/43990#issuecomment-1025692379)
get_uuid(Preferences)
currently_compiling()
precompile(Tuple{typeof(drop_clears), Any})
if hasmethod(Base.BinaryPlatforms.Platform, (String, String, Dict{String}))
precompile(load_preference, (Base.UUID, String, Nothing))
end

end # module Preferences
11 changes: 11 additions & 0 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,14 @@ function find_first_project_with_uuid(uuid::UUID)
end
return (nothing, nothing)
end

# Drop any nested `__clear__` keys:
function drop_clears(@nospecialize(data))
if isa(data, Dict{String,Any})
delete!(data, "__clear__")
for (_, v) in data
drop_clears(v)
end
end
return data
end