RISCV: Add CMake variable to set the system library directory #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I should probably also do a version number bump in this? (it seems like a patch release type of change to me). |
giordano
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Minor version bump is fine, but in Yggdrasil with the Update Manifest action we just checkout the tip of the default branch, don't need necessarily a new version tag.
RISCV installs place the libraries inside a folder that is named after the ABI, so we need to prompt CMake to search there.
imciner2
force-pushed
the
im/riscvlinking
branch
from
3f8e636 to
8bf7c17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RISCV installs place the libraries inside a folder that is named after the ABI, so we need to prompt CMake to search there. This should fix the toolchain issue discussed in JuliaPackaging/Yggdrasil#10922 (comment).
cc @eschnett @giordano