-
Notifications
You must be signed in to change notification settings - Fork 3
Test on Julia 1.0 and Julia LTS #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 4007454915Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Codecov ReportBase: 86.20% // Head: 86.20% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 3 3
Lines 29 29
=======================================
Hits 25 25
Misses 4 4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for the PR and the explanation, I agree. I guess part of it was playing around with the breaking CI. Seems to be a libraries issue with v1.6 |
The issue is JuliaPy/PyCall.jl#999, and the solution is to enforce the use of the Conda-version of libstdc++ with LD_PRELOAD. |
This reverts commit f15cdd4.
Hmm it still seems like Julia 1.6 with ubuntu-latest - x64 - conda is failing due to this workaround.
Maybe it's worth bypassing the requirements this time? |
I wanted to fix it today, unfortunately didn't manage to continue with this PR yesterday. |
Yeah sorry for the mess, can't reproduce any of this on my local machine so just tweaking and seeing what CI does. |
OK, everything works apart from Windows + Julia 1.0. This remaining test failure is caused by JuliaPy/Conda.jl#230. |
We should test at least the oldest Julia version that we claim to support as well. I have seen in many projects how easy it is to accidentally introduce changes that break compatibility with older versions such as Julia 1.0. IMO it's fine to introduce them and drop support for e.g. Julia < 1.6 (I think generally one should aim for supporting at least Julia LTS) but if we don't run the tests we won't notice these incompatibilities.
Additionally, the PR removes tests with '1.8' since that is (currently) the same as '1' anyway ('1' points to the latest stable Julia release which is 1.8 at the moment). Instead I propose testing the LTS version as well, i.e., (currently) Julia 1.6.