-
Notifications
You must be signed in to change notification settings - Fork 3
Added empircal_sinkhorn_divergence
function
#13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added empircal_sinkhorn_divergence
function
#13
Conversation
Pull Request Test Coverage Report for Build 902931689Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you make the new function consistent with the existing ones? Ie,
- remove all keyword arguments
- remove all more detailed explanations and link to POT instead
- add a doctest example such that coverage stays at 100%
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor suggestions left. Can you update the version number as well?
I don't know what is this error with JuliaNightly, but it looks like it's not actually related to my PR. |
No, they are known and caused by some deprecation in the Julia master branch that is not handled in PyCall yet (due to the deprecations the output of the doctests is different). |
Thanks for the PR, I'll make a new release right away! |
No description provided.