[WIP] Do not (mis)use objective as state #1212
Draft
+637
−563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
2 times, most recently
from
935c749 to
93e8f31
Compare
pkofod
reviewed
Nov 26, 2025
| end | ||
|
|
||
| if g_calls(d) > 0 && !all(isfinite, gradient(d)) | ||
| if hasproperty(state, :g_x) && !all(isfinite, state.g_x) |
Member
There was a problem hiding this comment.
could in principle add methods to isfinite_gradient and isfinite_hessian that you introduced for the objective? I suppose they are sufficiently similar in nature to share the function?
Member
There was a problem hiding this comment.
if it's only used once of course... then it's maybe overkill :) I suppose in termination code as well..
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
2 times, most recently
from
ec47faa to
ac80b59
Compare
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
from
ac80b59 to
e3f747e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much WIP, and I might have to start over again. Fixes #1210 (comment) by not (mis)using objective functions as states. Instead, this PR proposes to add
f_xandg_xfields to the optimization states (where needed), similar to already existingx_previous,f_x_previousandg_x_previousfields.