'only' constructors with TwiceDifferentiableHv #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=========================================
+ Coverage 93.46% 93.6% +0.13%
=========================================
Files 10 10
Lines 490 500 +10
=========================================
+ Hits 458 468 +10
Misses 32 32
Continue to review full report at Codecov.
|
tlienart
changed the title
tlienart
changed the title
Member
|
Welcome to the frightening world of NLSolversBase :) I will have a look as soon as possible. Thanks |
Contributor
Author
|
bump? |
Member
|
Great, looks good! Sorry for the long wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in view of JuliaNLSolvers/Optim.jl#738 @pkofod
only_fg_and_hvfor a constructor where only these two things are providedonly_fghvfor a constructor that looks likeonly_fghand allows re-using computations for the construction ofHv(a common trick using the construction of the gradient to getHv, see issue quoted above).This may break Optim in that the call tofgis now the "standard" format used elsewhere IE:(f, g, x)instead of just(g, x); I'll open a PR for Optim soon too.PS: failure on nightly are due to the project toml not being up to date, see PR #108Edit marked as "do not merge" for now, the ambiguity of calling convention fornow ok, see also JuliaNLSolvers/Optim.jl#742fgeither with (g, x) or (f, g, x) is causing me some trouble