Skip to content

Commit

Permalink
Don't filter example tests based on environment. (#116)
Browse files Browse the repository at this point in the history
Travis, AppVeyor, and CIBot all fail when there  are breaking
changes between LineSearches and downstream packages, such as Optim,
that are also used in the examples.
Instead of filtering tests based on CI environment, we'll just have to
remember to add the tests back when the most recent downstream
application works.
  • Loading branch information
anriseth authored and pkofod committed Jun 5, 2018
1 parent ca3ce1a commit 64f0414
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 16 deletions.
11 changes: 3 additions & 8 deletions docs/generate.jl
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
# generate examples
import Literate

# We shouldn't run the examples that require Optim in Travis/CI,
# because an update in LineSearches may be breaking with the
# most recently tagged Optim version.
if get(ENV, "CI", "") == "true"
ONLYSTATIC = ["optim_linesearch.jl", "optim_initialstep.jl"]
else
ONLYSTATIC = ["",]
end
# TODO: Remove items from `SKIPFILE` as soon as they run on the latest
# stable `Optim` (or other dependency)
ONLYSTATIC = ["optim_linesearch.jl", "optim_initialstep.jl"]

EXAMPLEDIR = joinpath(@__DIR__, "src", "examples")
GENERATEDDIR = joinpath(@__DIR__, "src", "examples", "generated")
Expand Down
11 changes: 3 additions & 8 deletions test/examples.jl
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
@testset "Literate examples" begin
# We shouldn't run the examples that require Optim in Travis/CI,
# because an update in LineSearches may be breaking with the
# most recently tagged Optim version.
if get(ENV, "CI", "") == "true"
SKIPFILE = ["optim_linesearch.jl", "optim_initialstep.jl"]
else
SKIPFILE = ["",]
end
# TODO: Remove items from `SKIPFILE` as soon as they run on the latest
# stable `Optim` (or other dependency)
SKIPFILE = ["optim_linesearch.jl", "optim_initialstep.jl"]

EXAMPLEDIR = joinpath(@__DIR__, "../docs/src/examples")

Expand Down

0 comments on commit 64f0414

Please sign in to comment.