support AtomsBase v0.4 #25
Conversation
|
thank you. Doesn't this need updates to AtomsCalculatorsUtilities first though? In particular issue ACU issue # 9 |
|
The tests need the new version to run properly. It does pass on my computer with correct versions though |
|
Well, they will pass here as well because they will just install the old ACU which restricts AB to < 0.4. So I prefer to first update ACU to be AB 0.4 compatible (even if it means a breaking change) and then come back to this PR? |
|
Yes I am doing that atm. ACU will be tagged new release once the CI passes. Then I will come to this. There is also a bug with Lennard-Jones potential, so I try to get in a fix for that too. |
|
great, thank you. |
|
AtomsBuilder needs an update too, to get the tests run on ABv04 |
about to be merged into General |
No description provided.