Skip to content

fix type-instability of logabsbeta #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevengj merged 2 commits into from
Jul 3, 2021
Merged

fix type-instability of logabsbeta #332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1b950a
fix type-instability of logabsbeta
stevengj Jul 2, 2021
06ae64b
make logabsgamma also return Int
stevengj Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/gamma.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,12 +620,12 @@ gamma(x::Number) = gamma(float(x))
function logabsgamma(x::Float64)
signp = Ref{Int32}()
y = ccall((:lgamma_r,libm), Float64, (Float64, Ptr{Int32}), x, signp)
return y, signp[]
return y, Int(signp[])
end
function logabsgamma(x::Float32)
signp = Ref{Int32}()
y = ccall((:lgammaf_r,libm), Float32, (Float32, Ptr{Int32}), x, signp)
return y, signp[]
return y, Int(signp[])
end
logabsgamma(x::Real) = logabsgamma(float(x))
logabsgamma(x::Float16) = Float16.(logabsgamma(Float32(x)))
Expand Down Expand Up @@ -668,7 +668,7 @@ loggamma(x::Number) = loggamma(float(x))

function loggamma(x::Real)
(y, s) = logabsgamma(x)
s < 0.0 && throw(DomainError(x, "`gamma(x)` must be non-negative"))
s < 0 && throw(DomainError(x, "`gamma(x)` must be non-negative"))
return y
end

Expand Down Expand Up @@ -808,7 +808,8 @@ function logabsbeta(a::T, b::T) where T<:Real
if a <= 0 && isinteger(a)
if a + b <= 0 && isinteger(b)
r = logbeta(1 - a - b, b)
sgn = iseven(Int(b)) ? 1 : -1
# in julia ≥ 1.7, iseven doesn't require Int (julia#38976)
sgn = iseven(@static VERSION ≥ v"1.7" ? b : Int(b)) ? 1 : -1
return r, sgn
else
return -log(zero(a)), 1
Expand All @@ -825,7 +826,7 @@ function logabsbeta(a::T, b::T) where T<:Real
ya, sa = logabsgamma(a)
yb, sb = logabsgamma(b)
yab, sab = logabsgamma(a + b)
(ya + yb - yab), (sa*sb*sab)
(ya + yb - yab), Int(sa*sb*sab)
end
logabsbeta(a::Real, b::Real) = logabsbeta(promote(a, b)...)

Expand All @@ -838,12 +839,12 @@ function logabsgamma(x::BigFloat)
z = BigFloat()
lgamma_signp = Ref{Cint}()
ccall((:mpfr_lgamma,:libmpfr), Cint, (Ref{BigFloat}, Ref{Cint}, Ref{BigFloat}, Int32), z, lgamma_signp, x, ROUNDING_MODE[])
return z, lgamma_signp[]
return z, Int(lgamma_signp[])
end

function loggamma(x::BigFloat)
(y, s) = logabsgamma(x)
s < 0.0 && throw(DomainError(x, "`gamma(x)` must be non-negative"))
s < 0 && throw(DomainError(x, "`gamma(x)` must be non-negative"))
return y
end
if Base.MPFR.version() >= v"4.0.0"
Expand Down