Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Extrapolation subtype of AbstractExtrapolation #141

Merged
merged 1 commit into from
Mar 14, 2017
Merged

make Extrapolation subtype of AbstractExtrapolation #141

merged 1 commit into from
Mar 14, 2017

Conversation

Evizero
Copy link
Contributor

@Evizero Evizero commented Mar 14, 2017

No description provided.

@timholy
Copy link
Member

timholy commented Mar 14, 2017

Seems fine to me. I'm not even sure why we have the Wrapper version. It seems to have been added in #47, care to comment, @tlycken?

@tomasaschan
Copy link
Contributor

Heh, it's been a while... I think what I had in mind was to allow for dispatch on wrappers (scalings, extrapolations, whatevs...) that didn't also work for actual interpolation objects, but it doesn't seem to be used like that anywhere in the library.

Since AbstractExtrapolation{...} <: AbstractInterpolationWrapper{...} this change should be totally fine (and is probably more in line with what I intended at some point anyway).

Thanks, @Evizero!

@tomasaschan tomasaschan merged commit 57ec164 into JuliaMath:master Mar 14, 2017
@Evizero
Copy link
Contributor Author

Evizero commented Mar 14, 2017

happy to contribute. Would you mind tagging v0.3.9 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants