Skip to content

Prevent allocations for FD{Int128} by freezing max_exp10(Int128) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Prevent allocations for FD{Int128} by freezing max_exp10(Int128) #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d1439
Prevent allocs for FD{Int128} by freeze max_exp10
NHDaly Nov 8, 2018
349643c
Improve comment for freezing `max_exp10(Int128)`
NHDaly Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/FixedPointDecimals.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,9 @@ function max_exp10(::Type{T}) where {T <: Integer}
end

max_exp10(::Type{BigInt}) = -1
# Freeze the evaluation for Int128, since max_exp10(Int128) is too compilicated to get
# optimized away by the compiler during const-folding.
@eval max_exp10(::Type{Int128}) = $(max_exp10(Int128))

"""
coefficient(::Type{FD{T, f}}) -> T
Expand Down