Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use MKL_jll instead of Conda during build #127

Merged
merged 5 commits into from
Dec 5, 2019

Conversation

IanButterworth
Copy link
Contributor

Trying to provide MKL through MKL_jll rather than Conda during build (#118)

Currently hits the following in Julia 1.3.0

julia> ENV["JULIA_FFTW_PROVIDER"]="MKL"
"MKL"

(FFTW) pkg> build
  Building FFTW  `~/Documents/GitHub/FFTW.jl/deps/build.log`
 Resolving package versions...

(FFTW) pkg> test
   Testing FFTW
 Resolving package versions...
Intel MKL FATAL ERROR: Cannot load libmkl_intel_thread.dylib.
ERROR: Package FFTW errored during testing

@IanButterworth
Copy link
Contributor Author

Seems like we also need IntelOpenMP, and the IntelOpenMP build_tarball.jl needs updating, and looks non-standard

@IanButterworth IanButterworth mentioned this pull request Dec 2, 2019
@giordano
Copy link
Member

giordano commented Dec 4, 2019

Pull request for IntelOpenMP at JuliaPackaging/Yggdrasil#259

@IanButterworth
Copy link
Contributor Author

All platforms that were being tested on master are passing.

However, Windows MKL wasn't being tested, but is failing with:

ERROR: LoadError: ArgumentError: FFTW plan applied to array with wrong memory alignment

I've PR'd to add windows MKL tests to master, and it's still failing, but with a different error:

ERROR: LoadError: LoadError: could not load library "C:\Users\travis\.julia\conda\3\Library\bin\libmkl_rt"
The specified module could not be found.

@ararslan ararslan merged commit 8a9197a into JuliaMath:master Dec 5, 2019
@ararslan
Copy link
Member

ararslan commented Dec 5, 2019

Thanks for this. Seems the README is now outdated, as it says that it uses Conda. Would you be willing to update that as well, @ianshmean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants