-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
reduce allocations in dims_howmany (#269)
* reduce allocations in dims_howmany * Update src/fft.jl Co-authored-by: Steven G. Johnson <stevenj@mit.edu> * Dont collect size tuple * filter for Int/Tuple regions * use tuple instead of vector region at more places * remove unused methods * test region collections * bump version to v1.7.0 --------- Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
- Loading branch information
Showing
3 changed files
with
66 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4a00b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevengj could you tag a release? Thanks!
e4a00b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it should be a patch release, since it looks like there are no new features or API additions/changes?
e4a00b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it a minor version bump, as in 82a99dc, the type parameters of
r2rFFTWPlan
were changed. This will be mildly breaking, e.g. inFastTransforms.jl
. This shouldn't breakHadamard.jl
, as the type parameter is now uniformly aVector{Int32}
, as in https://github.com/JuliaMath/Hadamard.jl/pull/18/files. Ideally, the version bump should have been in 82a99dc, but the version was not bumped correctly in that commit. It's fixed here.e4a00b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle bump @stevengj, this would help with type-inference downstream in
FastTransforms.jl
e4a00b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaRegistrator register
e4a00b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registration pull request created: JuliaRegistries/General/85320
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via: