Skip to content

Commit

Permalink
Improve inferrability
Browse files Browse the repository at this point in the history
Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com>
  • Loading branch information
topolarity and gbaraldi committed Oct 9, 2024
1 parent f888022 commit 55b8143
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/fft.jl
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,9 @@ unsafe_convert(::Type{PlanPtr}, p::FFTWPlan) = p.plan
# This is accomplished by the maybe_destroy_plan function, which is used as the plan finalizer.

# these functions should only be called while the fftwlock is held
unsafe_destroy_plan(plan::FFTWPlan{<:fftwDouble}) =
unsafe_destroy_plan(@nospecialize(plan::FFTWPlan{<:fftwDouble})) =
ccall((:fftw_destroy_plan,libfftw3[]), Cvoid, (PlanPtr,), plan)
unsafe_destroy_plan(plan::FFTWPlan{<:fftwSingle}) =
unsafe_destroy_plan(@nospecialize(plan::FFTWPlan{<:fftwSingle})) =
ccall((:fftwf_destroy_plan,libfftw3f[]), Cvoid, (PlanPtr,), plan)

const deferred_destroy_lock = ReentrantLock() # lock protecting the deferred_destroy_plans list
Expand All @@ -335,7 +335,12 @@ function destroy_deferred()
# we'll do nothing (the other function will eventually run destroy_deferred).
if !isempty(deferred_destroy_plans) && trylock(fftwlock)
try
foreach(unsafe_destroy_plan, deferred_destroy_plans)
@static if Base.VERSION >= v"1.9"
@inline foreach(unsafe_destroy_plan, deferred_destroy_plans)

Check warning on line 339 in src/fft.jl

View check run for this annotation

Codecov / codecov/patch

src/fft.jl#L338-L339

Added lines #L338 - L339 were not covered by tests
else
# call-site @inline isn't supported on old versions of Julia
foreach(unsafe_destroy_plan, deferred_destroy_plans)

Check warning on line 342 in src/fft.jl

View check run for this annotation

Codecov / codecov/patch

src/fft.jl#L342

Added line #L342 was not covered by tests
end
empty!(deferred_destroy_plans)
finally
unlock(fftwlock)
Expand Down

0 comments on commit 55b8143

Please sign in to comment.