-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stirlings2 bug #92
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 95.79% 95.29% -0.50%
==========================================
Files 8 8
Lines 642 638 -4
==========================================
- Hits 615 608 -7
- Misses 27 30 +3
Continue to review full report at Codecov.
|
function stirlings2(n::Integer, k::Integer) | ||
n >= 0 || throw(DomainError("n")) | ||
|
||
if n == k == 0; one(n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use standard formatting?
There is also #126, let's compare those two. |
stirlings2
is implemented twice in this package.stirlings2
is correct but recursive and slow.nfixedsetpartitions
is bugged eg. it silently overflows.stirlings2
is slow :nfixedsetpartitions
is bugged :SEE