Fixes for nightly #111
Merged
Fixes for nightly #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 96.95% 96.96% +0.01%
==========================================
Files 3 3
Lines 197 198 +1
==========================================
+ Hits 191 192 +1
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Andy Dienes <51664769+adienes@users.noreply.github.com>
|
Thanks! I'll merge this to fix CI but @xal-0 can comment afterwards. |
|
Yep, this is unintentional (opened JuliaLang/julia#59755). Thanks for the bug report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if 71c8982 is adapting to intended changes or working around a bug. Edit: this started in JuliaLang/julia#58279. @xal-0 would yo uhappen to know if this change in behaviour is a bug or a minor change?
@adienes I gave you co-author on 1c063b3 since it's basically a "backport" of JuliaLang/julia#59668
I also bumped the version, could we tag a release as soon as this is merged?