Use broadcasting rather than BLAS calls #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haampie
changed the title
. rather than BLAS calls
haampie
force-pushed
the
feature-blas-1-as-broadcast
branch
from
765fb8f to
e894d69
Compare
Member
|
I still think this is fine but I realized one catch here. If you want to try out these methods with a new fancy array type then there is a tax from using dots since supporting broadcasting is much harder than supporting BLAS-1. |
Member
Author
|
True, I had to do it in the test of lsmr and it took me a while to figure out how to do it. Hopefully the docs are clear when Julia 1.0 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181. Some code benefits here, like cg, chebyshev and bicgstabl. The only downside is that we're missing threading of openblas, but that helps only marginally on the CPU for BLAS 1.